tvalentyn commented on pull request #11966: URL: https://github.com/apache/beam/pull/11966#issuecomment-642164503
Seeing a failure in PortableRunnerTestWithExternalEnv.test_error_traceback_includes_user_code, not sure if related. The change LGTM and verified that it addresses [BEAM-10217]. Would it make sense to add this test: https://github.com/apache/beam/pull/11954/commits/91d6469e05b61df0bb19f2442b159129ea8ddeef#diff-f14ce51d033ed4ff23353402681571ecR195 ? If so I can add a commit to your PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
