lukecwik commented on pull request #11972: URL: https://github.com/apache/beam/pull/11972#issuecomment-642224159
> Thanks, Kyle! > > I'm curious with which runner we will run into this issue. Based on the proto, the `url` should be required for `ApiServiceDescriptor`: > > https://github.com/apache/beam/blob/c496ae56d1b066c895fdf273d3975bd8baf1a56f/model/pipeline/src/main/proto/endpoints.proto#L32-L40 The problem is that protos default isn't `null` but the default empty instance so the check should really be whether it is not the default instance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
