lostluck commented on a change in pull request #11999:
URL: https://github.com/apache/beam/pull/11999#discussion_r439544557
##########
File path: sdks/go/pkg/beam/testing/passert/sum.go
##########
@@ -22,9 +22,9 @@ import (
"github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
)
-// Sum validates that the incoming PCollection<int> is a singleton
-// with the given value. Specialized version of Equals that avoids
-// a lot of machinery for testing.
+// Sum validates that the sum and count of elements in the incoming
PCollection<int> is
+// the same as the given sum and count, under coder equality. Specialized
version of Equals
+// that avoids a lot of machinery for testing.
Review comment:
Can we also change the last sentence to start: "Sum is a specialized
version ...". GoDocs and comments should be full sentences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
