lostluck commented on a change in pull request #11989:
URL: https://github.com/apache/beam/pull/11989#discussion_r439546660
##########
File path: sdks/go/pkg/beam/core/runtime/coderx/string.go
##########
@@ -23,6 +23,8 @@ import (
// NewString returns a coder for the string type. It uses the native
// []byte to string conversion.
+//
+// Only for custom coder test use.
func NewString() (*coder.CustomCoder, error) {
Review comment:
Note that most things that aren't in the main `beam` package are really
intended for user use. I'll send a separate PR moving/removing this code, I
just didn't want this PR to become too messy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
