damccorm opened a new issue, #20369:
URL: https://github.com/apache/beam/issues/20369

   Combine docs for e.g. `mergeAccumulators` say
   
   "only the first accumulator may be modified and returned for efficiency; the 
other accumulators should not be mutated, because they may be shared with other 
code and mutating them could lead to incorrect results or data corruption."
   
   This is fine, but the API is odd: `AccumT mergeAccumulators(Iterable<AccumT> 
accumulators)` implies that all accumulators are treated equally.
   
   It has been suggested to create a new one more like `AccumT 
mergeAccumulators(AccumT mutable, Iterable<AccumT> immutableAccums)`
   
   Imported from Jira 
[BEAM-10326](https://issues.apache.org/jira/browse/BEAM-10326). Original Jira 
may contain additional context.
   Reported by: kenn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to