tvalentyn commented on PR #17462: URL: https://github.com/apache/beam/pull/17462#issuecomment-1147494051
> @tvalentyn Changed the last few things. I kept run() and run_pipeline() as separate because there are plans to return an pipeline object from `run_pipeline()` for benchmark tests(still working on that). So I thought may be its better to have a separate method. Right now, I have a different PR working on top of this code by returning a pipeline object from `run_pipeline()` in a different file. I will try to refactor the code later if thats okay. It is important to write an example in a way that we can test it, so adding helper functions for testability is fine. However we should keep in mind that first and foremost this pipeline is an example, users will look at the code to potentially base their pipelines off it, so we should try to avoid unnecessary complexity if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
