lukecwik commented on a change in pull request #11821:
URL: https://github.com/apache/beam/pull/11821#discussion_r440427252
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionViews.java
##########
@@ -151,13 +279,103 @@
}
/**
- * Implementation which is able to adapt a multimap materialization to a
{@code T}.
+ * Implementation which is able to adapt an iterable materialization to a
{@code T}.
*
* <p>For internal use only.
*
* <p>Instantiate via {@link PCollectionViews#singletonView}.
*/
@Experimental(Kind.CORE_RUNNERS_ONLY)
+ private static class SingletonViewFn2<T> extends ViewFn<IterableView<T>, T> {
Review comment:
The intent is that SingletonViewFn/MultimapViewFn/... would be removed
and the SingletonViewFn2/MultimapViewFn2 would replace them once the JRH no
longer exists.
Added comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
