yeandy commented on issue #21721: URL: https://github.com/apache/beam/issues/21721#issuecomment-1148847895
Not sure if it should be static. A user may have two different PytorchModels that they want to distinguish. For example: 1. `namespace=PytorchClassification` and `namespace=PytorchRegression` OR 2. `namespace=PytorchImageClassification` and `namespace=PytorchImageSegmentation` Can you clarify where/how you will do the filtering of the metrics by calling `PytorchRunInference.get_name_space()`? I see that`get_metrics_namespace` is currently in the `InferenceRunner` class. But we only pass in the `ModelLoader` class into `RunInference`. Will this require moving `get_metrics_namespace` to a different class like `InferenceRunner`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
