scwhittle commented on code in PR #21740:
URL: https://github.com/apache/beam/pull/21740#discussion_r892250466
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtils.java:
##########
@@ -44,6 +44,10 @@ public class WindmillTimeUtils {
public static Instant windmillToHarnessTimestamp(long timestampUs) {
// Windmill should never send us an unknown timestamp.
Preconditions.checkArgument(timestampUs != Long.MIN_VALUE);
+ // Set windmill min timestamp to beam min timestamp
+ if (timestampUs == Long.MIN_VALUE + 1) {
+ return BoundedWindow.TIMESTAMP_MIN_VALUE;
+ }
Review Comment:
actually would other values (ie Long.MIN_VALUE + 2) also be problematic
(though that timestamp would be less likely to be observed)
maybe this should calculate result as before but then bounds check it with
TIMESTAMP.MIN_VALUE similar to how it bound checks TIMESTAMP_MAX_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
