lostluck commented on code in PR #17814:
URL: https://github.com/apache/beam/pull/17814#discussion_r893846108
##########
sdks/go/test/integration/integration.go:
##########
@@ -154,6 +164,8 @@ var dataflowFilters = []string{
// Dataflow does not automatically terminate the TestCheckpointing
pipeline when
// complete.
"TestCheckpointing",
+ // Dataflow does not drain jobs by itself.
Review Comment:
I'll note that we can add a programatic bit that could drain the job
automatically, in particular for this test. But that's a fair amount of work,
since we'd need to provide access to the JobID, and the Dataflow client, via
some kind of "running job" wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
