damccorm commented on code in PR #21775:
URL: https://github.com/apache/beam/pull/21775#discussion_r893919601
##########
.test-infra/metrics/grafana/dashboards/post-commit_tests.json:
##########
@@ -835,7 +835,7 @@
"hide": false,
"metricColumn": "none",
"rawQuery": true,
- "rawSql": "with days as (select date_trunc('day', dd) as day from
generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1
day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as
currently_failing\n FROM jira_issues, days\n
WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate >
days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels LIKE
'%currently-failing%')\n GROUP BY days.day\n
ORDER BY days.day)\nselect days.day as time,
greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left
outer join knowndays\non days.day = knowndays.day",
+ "rawSql": "with days as (select date_trunc('day', dd) as day from
generate_series( $__timeFrom()::timestamp, $__timeTo()::timestamp, '1
day'::interval) as dd),\n knowndays as (SELECT days.day, count(*) as
currently_failing\n FROM jira_issues, days\n
WHERE jira_issues.created < days.day AND (jira_issues.resolutiondate >
days.day OR jira_issues.resolutiondate is null) AND (jira_issues.labels @>
ARRAY['currently-failing'])\n GROUP BY days.day\n
ORDER BY days.day)\nselect days.day as time,
greatest(knowndays.currently_failing, 0) as currently_failing\nfrom days left
outer join knowndays\non days.day = knowndays.day",
Review Comment:
Note that I updated to `@>` which is the [postgresql contains
operator](https://www.postgresql.org/docs/9.5/functions-array.html) because
labels is actually a varchar[] not a varchar.
I haven't been able to get my test env quite right for this, but this should
do no harm since its currently failing
http://104.154.241.245/d/D81lW0pmk/post-commit-test-reliability?orgId=1&inspect=14&inspectTab=error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
