Abacn commented on PR #17749: URL: https://github.com/apache/beam/pull/17749#issuecomment-1151632465
> * I see some code changes, will that code still work with Hive 2.x? The changes are only involved in unit tests. Unit tests needs to run with Hive 3.x. The artifact built should not be affected. `EmbeddedMetastoreService.java`: this file is only used in unit test. The file itself is a trimmed-down version of a test in Hive source, as recorded in its comment. The change updated the file content to that in Hive 3.1.3 release. `resources/hive-site.xml`: hive config file used for EmbeddedMetastoreService which is only used in unit test. Also updated the file content to that in Hive 3.1.3 release. `HCatalogIOTest.java` and `BeamSqlHiveSchemaTest.java` are unit tests. The change reflects a breaking change of Hive 3 which removed CommandNeedRetryException and thus removed from EmbeddedMetastoreService.executeQuery's signature. > * Do we need to release another vendored Calcite? Note that release process is separate from the rest of Beam Probably not. Hive 2.1.0 used Calcite 1.6.0 and now Hive 3.1.3 uses Calcite 1.16.0 as dependencies. Looked at Beam release history vendored Calcite started on v1.20.0 since the release of Beam 2.16.0 and the reason of vendoring were not related to Hive. Will confirm with others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
