mxm commented on a change in pull request #12012:
URL: https://github.com/apache/beam/pull/12012#discussion_r440644321
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -941,15 +942,29 @@ def extend(self,
is_cached=False
):
# type: (...) -> _Future
+ # Make sure the input is a list of elements
+ elements = list(elements)
Review comment:
Yes, though we will iterate twice over elements. 1) for the cache 2) for
serializing the elements for the runner. Materializing to a list ensures that
the results will be the same. An Iterable could theoretically return different
results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
