lostluck commented on code in PR #17821:
URL: https://github.com/apache/beam/pull/17821#discussion_r894847247
##########
sdks/go/pkg/beam/core/runtime/harness/harness.go:
##########
@@ -371,6 +390,10 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
c.cache.CompleteBundle(tokens...)
mons, pylds := monitoring(plan, store)
+ if c.runnerCapabilities[URNMonitoringInfoShortID] {
+ mons = []*pipeline_v1.MonitoringInfo{}
+ }
Review Comment:
So this only accomplishes half the goal of the short-ids approach to
monitoring. While we are no longer sending the larger payloads, we are still
allocating and authoring them, which we should still avoid doing if we can
avoid it. The monitoring method is what needs changing to "understand" the
capabilities and provide one thing or another (or if we have no information,
both).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
