robertwb commented on code in PR #21777:
URL: https://github.com/apache/beam/pull/21777#discussion_r894879047
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -93,6 +95,100 @@ def batch_elements_kwargs(self) -> Mapping[str, Any]:
return {}
+class KeyedModelHandler(Generic[KeyT, ExampleT, PredictionT, ModelT],
Review Comment:
I played around with this a bit, don't see a way to really make things much
simpler. It is possible delete the generic, but then it becomes harder to
reason about the order of the nested arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
