TheNeuralBit commented on code in PR #21834: URL: https://github.com/apache/beam/pull/21834#discussion_r897397954
########## website/www/site/content/en/documentation/programming-guide.md: ########## @@ -6892,7 +6892,7 @@ Currently Python external transforms are limited to dependencies available in th #### 13.1.3. Creating cross-language Go transforms Go currently does not support creating cross-language transforms, only using cross-language -transforms from other languages; see more at [Issue 21767](https://github.com/apache/beam/issues/21767). +transforms from other languages; see more at [https://github.com/apache/beam/issues/21767](https://github.com/apache/beam/issues/21767). Review Comment: I think the existing one looks fine as-is, should we be changing it? ########## examples/notebooks/documentation/transforms/python/elementwise/pardo-py.ipynb: ########## @@ -23,7 +23,10 @@ "execution_count": null, "metadata": { "cellView": "form", - "id": "_-code" + "id": "_-code", + "vscode": { + "languageId": "python" + } Review Comment: are these changes intentional? ########## website/www/site/content/en/documentation/programming-guide.md: ########## @@ -5436,7 +5436,7 @@ _ = (p | 'Read per user' >> ReadPerUser() {{< /highlight >}} {{< highlight go >}} -This is not supported yet, see BEAM-10660. +This is not supported yet, see https://github.com/apache/beam/issues/20510. Review Comment: Should these be `[Issue 20510][https://github.com/apache/beam/issues/20510]`? ########## website/www/site/content/en/documentation/programming-guide.md: ########## @@ -2193,7 +2193,7 @@ Timers and States are explained in more detail in the {{< paragraph class="language-go" >}} **Timer and State:** -This feature isn't implemented in the Go SDK; see more at [Issue 20510](https://github.com/apache/beam/issues/20510). Once implemented, user defined Timer and State parameters can be used in a stateful DoFn. Review Comment: Same here and above ########## examples/notebooks/documentation/transforms/python/elementwise/pardo-py.ipynb: ########## @@ -23,7 +23,10 @@ "execution_count": null, "metadata": { "cellView": "form", - "id": "_-code" + "id": "_-code", + "vscode": { + "languageId": "python" + } Review Comment: Ah I guess vscode added them when it was used for find/replace. I suppose that's harmless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
