Amar3tto commented on code in PR #21765:
URL: https://github.com/apache/beam/pull/21765#discussion_r897895615
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -630,6 +631,7 @@ class BeamModulePlugin implements Plugin<Project> {
guava_testlib :
"com.google.guava:guava-testlib:$guava_version",
hadoop_client :
"org.apache.hadoop:hadoop-client:$hadoop_version",
hadoop_common :
"org.apache.hadoop:hadoop-common:$hadoop_version",
+ hadoop_mapred :
"org.apache.hadoop:hadoop-mapred:0.22.0",
Review Comment:
Thanks for noticing, I removed that dependency.
We can use `hadoop_mapreduce_client_core` instead.
##########
sdks/java/io/cdap/build.gradle:
##########
@@ -38,26 +38,35 @@ interface for integration with CDAP plugins."""
*/
dependencies {
- implementation library.java.avro
implementation library.java.cdap_api
implementation library.java.cdap_api_commons
implementation (library.java.cdap_common) {
- exclude module: "log4j-over-slf4j"
+ exclude module: 'log4j-over-slf4j'
}
implementation library.java.cdap_etl_api
implementation library.java.cdap_etl_api_spark
+ implementation library.java.cdap_hydrator_common
+ implementation library.java.guava
implementation library.java.hadoop_common
- implementation library.java.hadoop_mapreduce_client_core
+ implementation library.java.hadoop_mapred
implementation library.java.jackson_core
implementation library.java.jackson_databind
- implementation library.java.guava
implementation library.java.slf4j_api
implementation library.java.tephra
+ implementation library.java.vendored_guava_26_0_jre
implementation project(path: ":sdks:java:core", configuration: "shadow")
+ implementation project(":sdks:java:io:hadoop-format")
+ implementation "io.cdap.plugin:salesforce-plugins:1.4.0"
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
