yeandy commented on code in PR #21868:
URL: https://github.com/apache/beam/pull/21868#discussion_r897955352
##########
sdks/python/apache_beam/ml/inference/pytorch_inference.py:
##########
@@ -170,6 +183,9 @@ def run_inference(
For the same key across all examples, this will stack all Tensors values
in a vectorized format to optimize the inference call.
+
Review Comment:
Can we add inputs here?
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -76,29 +85,47 @@ def load_model(self) -> BaseEstimator:
def run_inference(
self, batch: Sequence[numpy.ndarray], model: BaseEstimator,
**kwargs) -> Iterable[PredictionResult]:
+ """Runs inferences on a batch of numpy arrays.
+
Review Comment:
Can we add inputs here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
