damccorm commented on code in PR #21835:
URL: https://github.com/apache/beam/pull/21835#discussion_r897994654
##########
runners/flink/job-server/flink_job_server.gradle:
##########
@@ -193,17 +193,17 @@ def portableValidatesRunnerTask(String name, boolean
streaming, boolean checkpoi
excludeCategories 'org.apache.beam.sdk.testing.UsesPerKeyOrderInBundle'
},
testFilter: {
- // TODO(BEAM-10016)
+ // TODO(https://github.com/apache/beam/issues/20269)
excludeTestsMatching
'org.apache.beam.sdk.transforms.FlattenTest.testFlattenWithDifferentInputAndOutputCoders2'
- // TODO(BEAM-12039)
+ // TODO(https://github.com/apache/beam/issues/20843)
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testDiscardingMode'
- // TODO(BEAM-12038)
+ // TODO(https://github.com/apache/beam/issues/20844)
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testLateDataAccumulating'
// TODO(BEAM-12710)
excludeTestsMatching
'org.apache.beam.sdk.testing.TestStreamTest.testFirstElementLate'
// TODO(BEAM-13498)
excludeTestsMatching
'org.apache.beam.sdk.transforms.ParDoTest$TimestampTests.testProcessElementSkew'
Review Comment:
Yeah, I agree that would be good to do - that probably would need to be
driven by SDK owners though (e.g. it would be hard for me to evaluate quickly
whether a ticket should have been resolved in the Java SDK)
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/ResumeFromCheckpointStreamingTest.java:
##########
@@ -351,8 +351,8 @@ public void process(ProcessContext c) {
}
/**
- * A custom PAssert that avoids using {@link
org.apache.beam.sdk.transforms.Flatten} until
- * BEAM-1444 is resolved.
+ * A custom PAssert that avoids using {@link
org.apache.beam.sdk.transforms.Flatten} until Issue
+ * 18144 is resolved.
Review Comment:
Yes - fixed
##########
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java:
##########
@@ -68,7 +68,8 @@
@RunWith(JUnit4.class)
@SuppressWarnings({
"rawtypes", // TODO(https://github.com/apache/beam/issues/20447)
- "unused" // TODO(BEAM-13271): Remove when new version of errorprone is
released (2.11.0)
+ "unused" // TODO(https://github.com/apache/beam/issues/21230): Remove when
new version of
+ // errorprone is released (2.11.0)
Review Comment:
Fixed manually!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
