lostluck commented on code in PR #21896: URL: https://github.com/apache/beam/pull/21896#discussion_r898325924
########## release/go-licenses/Dockerfile: ########## @@ -16,8 +16,11 @@ # limitations under the License. ############################################################################### -FROM golang:1.16-bullseye -RUN go get github.com/google/[email protected] +FROM golang:1.18-bullseye + +WORKDIR /usr/src/app +COPY go.mod ./ +RUN go install github.com/google/[email protected] Review Comment: We should file an issue to bump the version to the [latest version (1.2.1)](https://pkg.go.dev/github.com/google/[email protected]). Since we're trying to unblock things, we're probably fine not doing it in this PR. I'd consider just making the target @latest instead though, it's unlikely to cause breaking changes, and allow additional license detection over time. https://github.com/google/go-licenses/tags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
