nbali commented on code in PR #17775:
URL: https://github.com/apache/beam/pull/17775#discussion_r898454955
##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoByteBuddyUtils.java:
##########
@@ -190,15 +191,59 @@ class ProtoByteBuddyUtils {
private static final String DEFAULT_PROTO_GETTER_PREFIX = "get";
private static final String DEFAULT_PROTO_SETTER_PREFIX = "set";
+ // BEAM-14525: there is a slight difference between 'protoc' and Guava
CaseFormat regarding the
+ // camel case conversion
+ // - guava keeps the first character after a number lower case
+ // - protoc makes it upper case
+ // based on
+ //
https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L173-L208
+ @VisibleForTesting
+ static String convertProtoPropertyNameToJavaPropertyName(String input) {
Review Comment:
@kileys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
