TheNeuralBit commented on code in PR #21868:
URL: https://github.com/apache/beam/pull/21868#discussion_r898554493
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -76,13 +77,21 @@ def _validate_inference_args(inference_args):
class SklearnModelHandlerNumpy(ModelHandler[numpy.ndarray,
PredictionResult,
BaseEstimator]):
- """ Implementation of the ModelHandler interface for scikit-learn
- using numpy arrays as input.
- """
def __init__(
self,
model_uri: str,
model_file_type: ModelFileType = ModelFileType.PICKLE):
+ """ Implementation of the ModelHandler interface for scikit-learn
+ using numpy arrays as input.
+
+ Example Usage:
+ pcoll | RunInference(SklearnModelHandlerNumpy(model_uri="my_uri"))
Review Comment:
Unfortunate that these were missed, but let's do these in a follow-up PR
just to make sure we get the basic updates into the release cut. We can
probably cherrypick these minor changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
