tysonjh commented on pull request #12020: URL: https://github.com/apache/beam/pull/12020#issuecomment-645496516
> > Most important is noting the license, which is the same as JDK stdlib stuff: GPL 2.0 with classpath exception. (even with source retention best to be clear and safe) > > I found that the annotation is under both CDDL 1.1 and GPL 2.0 so I updated the comments accordingly. Could you review this please? I'd like to be sure it is correct. > > This PR doesn't fix the linked issue but is required AFAICT for building Beam locally with Java 11. I'm not sure exactly how the precommit phase is set up to do this so I need to investigate before merging this. The postcommit phase builds the direct runner with Java 8 and runs the validatesRunner task with Java 11: https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Direct_Java11.groovy I'll try this out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
