steveniemitz commented on code in PR #17802:
URL: https://github.com/apache/beam/pull/17802#discussion_r904023502
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/CoderUtils.java:
##########
@@ -107,6 +107,25 @@ public static <T> T decodeFromByteArray(
}
}
+ /** Decodes a value from the given stream, validating that no bytes are
remaining once decoded. */
+ public static <T> T decodeFromStream(Coder<T> coder, InputStream stream)
throws IOException {
+ return decodeFromStream(coder, stream, Coder.Context.OUTER);
+ }
+
+ /**
+ * Decodes a value from the given stream using a given context, validating
that no bytes are
+ * remaining once decoded.
+ */
+ public static <T> T decodeFromStream(Coder<T> coder, InputStream stream,
Coder.Context context)
+ throws IOException {
+ T result = coder.decode(stream, context);
+ if (stream.available() != 0) {
+ throw new CoderException(
+ stream.available() + " unexpected extra bytes after decoding " +
result);
+ }
+ return result;
+ }
Review Comment:
> which is not part of the public API surface
uhhhh lol we use CoderUtils and other stuff from util all over the place in
our code, it's not even marked as `@Internal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
