Abacn commented on code in PR #22046:
URL: https://github.com/apache/beam/pull/22046#discussion_r906275225
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1064,6 +1066,7 @@ class BeamModulePlugin implements Plugin<Project> {
// of the codebase. It is runtime so users can also take advantage of
them. The annotations themselves
// are MIT licensed (checkerframework is GPL and cannot be distributed)
implementation
"org.checkerframework:checker-qual:$checkerframework_version"
+ implementation
"org.checkerframework:checker-compat-qual:$checkercompatframework_version"
Review Comment:
I see the annotation. May replace with @Nonnull from
`org.checkerframework.checker.nullness.qual.NonNull` which is used elsewhere in
the codebase. compatqual is not updated in years and looks like a legacy
version?
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -1064,6 +1066,7 @@ class BeamModulePlugin implements Plugin<Project> {
// of the codebase. It is runtime so users can also take advantage of
them. The annotations themselves
// are MIT licensed (checkerframework is GPL and cannot be distributed)
implementation
"org.checkerframework:checker-qual:$checkerframework_version"
+ implementation
"org.checkerframework:checker-compat-qual:$checkercompatframework_version"
Review Comment:
I see the annotation. May replace with `@Nonnull` from
`org.checkerframework.checker.nullness.qual.NonNull` which is used elsewhere in
the codebase. compatqual is not updated in years and looks like a legacy
version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
