lukecwik commented on code in PR #22002:
URL: https://github.com/apache/beam/pull/22002#discussion_r906414654
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ShortIdMap.java:
##########
@@ -48,4 +53,30 @@ public synchronized MonitoringInfo get(String shortId) {
}
return monitoringInfo;
}
+
+ public synchronized Map<String, MonitoringInfo> get(List<String> shortIds) {
+ Map<String, MonitoringInfo> monitoringInfos = new
HashMap<>(shortIds.size());
Review Comment:
Slower as well and leads to additional object creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
