lukecwik commented on a change in pull request #11862:
URL: https://github.com/apache/beam/pull/11862#discussion_r442546599
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##########
@@ -179,25 +189,51 @@ public static ListHL7v2Messages readAll(List<String>
hl7v2Stores) {
return new ListHL7v2Messages(StaticValueProvider.of(hl7v2Stores),
StaticValueProvider.of(null));
}
+ /** Read all HL7v2 Messages from multiple stores as sendTime {@link
TimestampedValue}s. */
+ public static ListTimestampedHL7v2Messages
readAllWithTimestamps(List<String> hl7v2Stores) {
Review comment:
I think you can keep the static methods that exist and transition them
to use the builder underneath so you don't have to break the interface. This is
done in other IOs for common scenarios.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
