alvintanjianjia opened a new issue, #22059:
URL: https://github.com/apache/beam/issues/22059
**Summary**
I have identified a few classes with refactoring potential, specifically
DataflowPipelineOptions.java. The class was refactored once on Sep 4, 2020
along with other classes in commit 0542e260cc58a8e941faaeb1b4ee30bb7a04d7d0 .
Given the duration of the last refactoring, could it be possible to improve
this class further? I am probably not qualified and experienced enough to point
out the exact code needs to be refactored, given my limited knowledge of the
project and codebase.
**Urgency**
Low priority. For maintenance of code in the long run.
Hi,
I am currently doing some research on Estimating Time Taken for Software
Refactoring. Beam is one of my case studies being a highly popular project.
Would appreciate your kind feedback on the appropriateness of the estimated
time to refactor.
I am specifically looking at potential for refactoring, such as breaking
functions that are too long into shorter functions, or to remove code
duplication. Would you agree that there could be some modification to the code
to make it better in the listed classes? And if so, is the estimated time
appropriate to carry out the improvement? I will be grateful for any help you
can provide.
1. DataflowPipelineOptions.java - 4 hours
2. DefaultGcpRegionFactory.java - 2 hours
3. DataflowPipelineOptionsTest.java - 5 hours
4. DataflowRunnerTest.java - 4 hours
Thank you.
Regards,
Alvin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
