chamikaramj commented on a change in pull request #11911:
URL: https://github.com/apache/beam/pull/11911#discussion_r442566539
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java
##########
@@ -159,6 +159,16 @@ public void processInstructionRequests(Executor executor)
} catch (Error e) {
sendErrorResponse(e);
throw e;
+ } catch (IllegalStateException e) {
Review comment:
I don't think that will resolve the issue of runner waiting for a
response here and timing out (with a bad error in the case of Dataflow).
How about catching all exceptions here and sending a error response to the
runner set here:
https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto#L129
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
