alexeyinkin commented on code in PR #22098:
URL: https://github.com/apache/beam/pull/22098#discussion_r909678164
##########
playground/frontend/lib/modules/editor/components/pipeline_options_dropdown/pipeline_options_dropdown_body.dart:
##########
@@ -29,19 +29,16 @@ import
'package:playground/modules/editor/parsers/run_options_parser.dart';
const kOptionsTabIndex = 0;
const kRawTabIndex = 1;
-final kDefaultOption = [PipelineOptionController()];
-
class PipelineOptionsDropdownBody extends StatefulWidget {
final String pipelineOptions;
final void Function(String) setPipelineOptions;
final void Function() close;
- const PipelineOptionsDropdownBody({
- Key? key,
+ PipelineOptionsDropdownBody({
required this.pipelineOptions,
required this.setPipelineOptions,
required this.close,
- }) : super(key: key);
+ }) : super(key: ValueKey(pipelineOptions));
Review Comment:
So that the old state is dropped and options are re-parsed to new
controllers if they change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
