lostluck commented on code in PR #17799:
URL: https://github.com/apache/beam/pull/17799#discussion_r910170827
##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -80,7 +86,7 @@ func splitStringPair(e stringPair) (string, string) {
func init() {
// Register element types and DoFns.
beam.RegisterType(reflect.TypeOf((*stringPair)(nil)).Elem())
Review Comment:
I think we can avoid the manual register here since the register package is
handling it, right?
With the register package, the older RegisterType call basically becomes for
handling special situations when the type doesn't explicitly show up in a DoFn
parameter or return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
