damccorm commented on code in PR #22102:
URL: https://github.com/apache/beam/pull/22102#discussion_r910987035
##########
.test-infra/jenkins/LoadTestsBuilder.groovy:
##########
@@ -25,6 +25,7 @@ import static PythonTestProperties.LOAD_TEST_PYTHON_VERSION
class LoadTestsBuilder {
final static String DOCKER_CONTAINER_REGISTRY =
'gcr.io/apache-beam-testing/beam_portability'
+ final static String DOCKER_CONTAINER_REGISTRY_GO =
'gcr.io/apache-beam-testing/beam-sdk'
Review Comment:
Looks like we always exclusively get the go container - could we update to
`DOCKER_CONTAINER_GO =
'gcr.io/apache-beam-testing/beam-sdk/beam_go_sdk:latest'` (or maybe drop latest)
##########
.test-infra/jenkins/job_Publish_Docker_Snapshots.groovy:
##########
@@ -42,10 +42,9 @@ job('beam_Publish_Docker_Snapshots') {
rootBuildScriptDir(commonJobProperties.checkoutDir)
commonJobProperties.setGradleSwitches(delegate)
SUPPORTED_CONTAINER_TASKS.each { taskVer ->
- tasks(":sdks:python:container:${taskVer}:dockerPush")
+ tasks(":sdks:python:container:${taskVer}:dockerTagPush")
Review Comment:
I still don't quite get the difference between these two, but why do we need
to update the python task? Isn't it just failing on the Go SDK/can we just
remove the go one?
Same question about flink as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
