steveniemitz opened a new pull request, #22162:
URL: https://github.com/apache/beam/pull/22162
This fixes `ProxyInvocationHandler.as`, `DoFnSignatures.getSignature`, and
`ByteBuddyDoFnInvokerFactory.getByteBuddyInvokerConstructor` from #22161
The fixes to DoFnSignatures and ByteBuddyDoFnInvokerFactory are trivially
changing a Map to ConcurrentHashMap.
ProxyInvocationHandler is more involved, since multiple data structures must
be updated atomically on a cache miss. To do this we extract the relevant
structures into an immutable class. On a cache miss we construct a new
instance of it with new (also immutable) copies of the updated structures. The
trade-off here is slightly more garbage creation on a cache miss (since it
needs to copy the structures rather than mutate them), however since in
steady-state misses ~never occur, and the structures here in question are
generally small (~100s of elements).
The impact of these changes is very significant, without these changes my
test job spends ~30% of its time in the "start bundle" state, after these
changes (as well as ExecutionStateSampler), the % time goes down to ~1-2%.
R: @lukecwik
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
