mutianf commented on code in PR #17823: URL: https://github.com/apache/beam/pull/17823#discussion_r914967244
########## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/FakeResourceStats.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.bigtable; + +import com.google.cloud.bigtable.grpc.async.ResourceLimiterStats; +import java.io.Serializable; + +public class FakeResourceStats extends ResourceLimiterStats implements Serializable { Review Comment: Will it work if you move FakeResourceStats and FakeResourceStatsSupplier to BigtableIOTest? ########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java: ########## @@ -1431,4 +1492,25 @@ static void validateTableExists(BigtableConfig config, PipelineOptions options) } } } + + interface ResourceStatsSupplier extends Serializable { + ResourceLimiterStats getStats(); + } + + static class ResourceStatsSupplierImpl implements ResourceStatsSupplier, Serializable { + + private final String project; + private final String instance; + + ResourceStatsSupplierImpl(String project, String instance) { + Review Comment: extra line ########## sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java: ########## @@ -1563,6 +1565,33 @@ public void testWriteWithBigTableOptionsSetsBulkOptionsAndRetryOptions() { assertThat(options.getRetryOptions(), Matchers.equalTo(retryOptionsBuilder.build())); } + @Test + public void testWriteWithEnabledDataflowThrottleReporting() { + BigtableIO.Write write = + defaultWrite.withTableId("TEST-TABLE").withDataflowThrottleReporting(true); + + assertTrue(write.isDataflowThrottleReportingEnabled()); + } + + @Test + public void testWritePipelineWithDataflowThrottleReporting() { + final String table = "TEST-TABLE"; + service.createTable(table); + + BigtableConfig mockConfig = Review Comment: I think you can rename this to fakeConfig so it's consistent with your other naming ########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java: ########## @@ -1431,4 +1492,25 @@ static void validateTableExists(BigtableConfig config, PipelineOptions options) } } } + + interface ResourceStatsSupplier extends Serializable { Review Comment: would it work if this doesn't extend Serializable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
