robertwb commented on code in PR #22132:
URL: https://github.com/apache/beam/pull/22132#discussion_r915290698
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -348,12 +348,15 @@ def get_all_options(
del result[k]
if overrides:
- _LOGGER.warning("Discarding invalid overrides: %s", overrides)
+ if retain_unknown_options:
+ result.update(overrides)
Review Comment:
The difficulty is that the set of pipeline options is actually the union of
what's in result and what's in overrides. Also, we don't necessarily know what
the defaults are for values that don't come from flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
