steveniemitz opened a new pull request, #22190:
URL: https://github.com/apache/beam/pull/22190
This fixes the ExecutionStateSampler portion of #22161.
There's a couple options I've tried to remove the lock there:
- Switch activeTrackers back to a concurrent set, the problem here was that
deactivating a tracker could still race with the sampler thread and
double-sample a sampler. I'm not sure if this is a big enough deal to worry
about?
- Rather than worry about synchronization at all, push all add/remove/sample
operations into a queue and have a single thread consuming from it and
maintaining activeTrackers and doing the sampling. Doing so removes the race
above and simplifies the logic a lot (I think). I used the LMAX Disruptor queue
to handle the multi-consumer-single-producer setup here, but you could probably
use a built-in java concurrent blocking queue for this as well.
Happy to have a discussion on which to use, I figured LMAX would be fine
since opencensus uses it too and will usually be included anyways, but I don't
think the overhead of using a plain old java queue would be that bad either.
R: @lukecwik
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
