alexeyinkin commented on code in PR #21959: URL: https://github.com/apache/beam/pull/21959#discussion_r916774767
########## website/www/site/layouts/shortcodes/playground.html: ########## @@ -10,10 +10,13 @@ limitations under the License. See accompanying LICENSE file. */}} -<iframe - src="https://frontend-beta-dot-apache-beam-testing.appspot.com/embedded?enabled={{ .Get 0 }}&example={{ .Get 1 }}&code={{ .Get 2 }}" - width="100%" - height="{{ .Get 3 }}" - class="code-snippet playground" - allow="clipboard-write"> -</iframe> +<div id="playgroundIframeContainer"> + <iframe + src="https://frontend-beta-dot-apache-beam-testing.appspot.com/embedded?enabled={{ .Get 0 }}&example={{ .Get 1 }}&code={{ .Get 2 }}" Review Comment: Better use named parameters in this shortcode since we already have 5. They will only be adding up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
