je-ik commented on code in PR #22183:
URL: https://github.com/apache/beam/pull/22183#discussion_r917680579
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -2366,6 +2361,11 @@ protected BulkIOBaseFn(BulkIO bulkSpec) {
this.spec = bulkSpec;
}
+ @Override
+ public Duration getAllowedTimestampSkew() {
+ return Duration.millis(Long.MAX_VALUE);
Review Comment:
Elements should not be assigned to expired windows, because the elements are
assigned to windows present in the active bundle. This is just a workaround the
check for element output timestamp which is too restrictive. There is no need
for elements not to be output with lower timestamp than timestamp of the
current element, it is only needed not to output elements that change from
on_time to late (or droppable). It would be best to relax the restriction,
though it seems it would require a runner-specific code to be provided, because
the check does not know about bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
