alexeyinkin commented on code in PR #21959:
URL: https://github.com/apache/beam/pull/21959#discussion_r918060976
##########
website/www/site/assets/js/fix-playground-nested-scroll.js:
##########
@@ -10,10 +10,10 @@
// License for the specific language governing permissions and limitations
under
// the License.
-$('#playgroundIframeContainer').on('click', function(_) {
- $('#playgroundIframe').css('pointer-events', 'auto');
+$('.playgroundIframeContainer').on('click', function(_) {
+ $('.playgroundIframeContainer > iframe').css('pointer-events', 'auto');
Review Comment:
I think it's better to add and remove classes to the div instead if tweaking
styles at runtime. I suggest to:
1. Rename this class to `playground-iframe-wrapper-no-scroll` so it is
self-descriptive. (Dashes are for this to go in line with my parallel work on
embedding).
2. On click, add another class `playground-iframe-wrapper-scroll` that sets
`pointer-events: auto` on iframe so it takes over.
3. On mouse leave, remove `playground-iframe-wrapper-scroll` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
