damccorm commented on code in PR #22223:
URL: https://github.com/apache/beam/pull/22223#discussion_r918257991


##########
.test-infra/jenkins/committers_list_generator/main.py:
##########
@@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path):
     connection = None
     try:
         ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path)
-        ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND)

Review Comment:
   Ah, I see - so now it should be inferred and we don't need the explicit 
option (and it throws). Thanks for the context, just wanted to make sure we 
weren't losing something we'd need to replace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to