lukecwik commented on code in PR #22190:
URL: https://github.com/apache/beam/pull/22190#discussion_r918286937


##########
sdks/java/harness/jmh/src/main/java/org/apache/beam/fn/harness/jmh/control/ExecutionStateSamplerBenchmark.java:
##########
@@ -103,33 +104,38 @@ public void tearDown() {
   }
 
   @Benchmark
-  @Threads(1)
-  public void testTinyBundleRunnersCoreStateSampler(RunnersCoreStateSampler 
state)
+  @Threads(10)
+  @Fork(1)
+  public void testTinyBundleRunnersCoreStateSampler(RunnersCoreStateSampler 
state, Blackhole bh)

Review Comment:
   sgtm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to