prodriguezdefino commented on PR #21813:
URL: https://github.com/apache/beam/pull/21813#issuecomment-1183764037

   > Overall these changes look good, but this needs at least a few tests
   
   Added few checks to existing test that validates misconfigurations of this 
properties. 
   
   There were no existing test that validates expectations on positive 
configurations (from previous existing functionality). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to