ryanthompson591 commented on code in PR #22088: URL: https://github.com/apache/beam/pull/22088#discussion_r921286515
########## sdks/python/apache_beam/ml/inference/sklearn_inference_regression_it_test.py: ########## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""End-to-End test for Sklearn Inference using the Japanese housing regression +sample code.""" + +import logging +import unittest +import uuid + +import pytest + +from apache_beam.examples.inference import sklearn_japanese_housing_regression +from apache_beam.io.filesystems import FileSystems +from apache_beam.testing.test_pipeline import TestPipeline + + +def file_lines_sorted(filepath): + with FileSystems().open(filepath) as f: + lines = f.readlines() + lines = [l.decode('utf-8').strip('\n') for l in lines] + return sorted(lines) + + [email protected] [email protected]_sklearn [email protected]_postcommit +class SklearnInferenceRegression(unittest.TestCase): Review Comment: OK, I made this change, it makes sense to keep these tests together. I wasn't able to get hte test to run with gradlew, so I just used my local files and ran the test. All I really needed to change was a flag to modify the numbers appended to the output file and the test passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
