TobKed commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r443506463
##########
File path: .github/workflows/build_wheels.yml
##########
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+ branches:
+ - master
+ - release-*
+ tags:
+ - v*
+
+jobs:
+
+ build_source:
+ runs-on: ubuntu-18.04
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Install python
+ uses: actions/setup-python@v2
+ with:
+ python-version: 3.7
+ - name: Get build dependencies
+ working-directory: ./sdks/python
+ run: python3 -m pip install cython && python3 -m pip install -r
build-requirements.txt
+ - name: Install wheels
+ run: python3 -m pip install wheel
+ - name: Buld source
+ working-directory: ./sdks/python
+ run: python3 setup.py sdist --formats=gztar,zip
+ - name: Unzip source
+ working-directory: ./sdks/python
+ run: unzip dist/$(ls dist | grep .zip | head -n 1)
+ - name: Rename source directory
+ working-directory: ./sdks/python
+ run: mv $(ls | grep apache-beam) apache-beam-source
+ - name: Upload source
+ uses: actions/upload-artifact@v2
+ with:
+ name: source
+ path: sdks/python/apache-beam-source
+ - name: Upload compressed sources
+ uses: actions/upload-artifact@v2
+ with:
+ name: source_gztar_zip
Review comment:
>I think it would be much cleaner and explicit. Did I understand
correctly your idea?
Yes. Your understanding is correct. This sounds good to me.
I renamed steps. Please take a look is there no mistakes.
> Clean up:
Both options are good. Can we do both?
Sure. We can do both.
Related to versioning and lifecycle management: I added information in the
PR description.
For periodic cleaning tasks I created separate dependent draft PR:
https://github.com/apache/beam/pull/12049
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
