waltage commented on PR #21867: URL: https://github.com/apache/beam/pull/21867#issuecomment-1185057642
> This looks structurally fine to me. My only question is if we have an integration test suite that could be expanded to include a test that leverages these parameter, to verify they work as expected If you could point me in the right direction (like a particular directory or a test file), I can work on adding one. My original thinking was that any integration testing on this particular "feature" would reduce to a change-detector test given that the implementation is setting the parameter on the proto request itself ([here](https://github.com/apache/beam/pull/21867/commits/4083fa49cb6e9955b2f7eca70727c8571b5652ed#diff-5427a5d3887eb695cefde082c58575a2372972996b547d55961abeb4f7bc3debR534)), but it is duly noted that the string values themselves are not explicitly being tested anywhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
