ryanthompson591 commented on code in PR #22282:
URL: https://github.com/apache/beam/pull/22282#discussion_r922296170
##########
sdks/python/apache_beam/ml/inference/base_test.py:
##########
@@ -128,9 +136,21 @@ def test_run_inference_impl_inference_args(self):
pcoll = pipeline | 'start' >> beam.Create(examples)
inference_args = {'key': True}
actual = pcoll | base.RunInference(
- FakeModelHandlerExtraInferenceArgs(), inference_args=inference_args)
+ FakeModelHandlerExpectedInferenceArgs(),
+ inference_args=inference_args)
assert_that(actual, equal_to(examples), label='assert:inferences')
+ def test_unexpected_inference_args_passed(self):
+ with self.assertRaisesRegex(ValueError, r'inference_args were provided'):
+ with TestPipeline() as pipeline:
+ examples = [1, 5, 3, 10]
+ pcoll = pipeline | 'start' >> beam.Create(examples)
+ inference_args = {'key': True}
+ actual = pcoll | base.RunInference(
+ FakeModelHandlerFailsOnInferenceArgs(),
+ inference_args=inference_args)
+ assert_that(actual, equal_to(examples), label='assert:inferences')
Review Comment:
Nope removed line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
