mosche commented on PR #22260: URL: https://github.com/apache/beam/pull/22260#issuecomment-1190095360
Thanks for having a look @lukecwik! Have a great time off :) I've had a look at that plugin before. The reason why I'd be a bit reluctant to use the plugin is the lack of configuration. It uses the simple name of a benchmark class as measurement name. We might risk collision that way, especially across modules if we keep using a single db. But of course, we could start using multiple dbs with a db per JMH module. Another small point is that all JMH params + the test name are treated as fields (instead of tags) making these just one series per benchmark class where, in fact, each combination is - at least logically - a separate series of data. Though, that's certainly more cosmetic and probably done to keep series cardinality low. Also, from a query perspective it won't be very important as data points will be very infrequent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
