echauchot commented on code in PR #22157:
URL: https://github.com/apache/beam/pull/22157#discussion_r925731759
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/structuredstreaming/SparkSessionRule.java:
##########
@@ -37,23 +39,43 @@ public SparkSessionRule(String sparkMaster, Map<String,
String> sparkConfig) {
builder = SparkSession.builder();
sparkConfig.forEach(builder::config);
builder.master(sparkMaster);
+ builder.config("spark.sql.shuffle.partitions",
numDriverCores(sparkMaster));
}
public SparkSessionRule(KV<String, String>... sparkConfig) {
- this("local", sparkConfig);
+ this("local[2]", sparkConfig);
Review Comment:
was just mentioning this as it is the custom for beam users. But I'm not
sure it will entails any trouble for them. And I agree with the arguments you
gave I'd add that local[1] could also obfuscate serialization issues. Fair
enough for local[2]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
