echauchot commented on PR #22157: URL: https://github.com/apache/beam/pull/22157#issuecomment-1190452163
> > as a general advice, it is easier for review process if you do tiny commits that address one comment (we will squash anyway) that way I can track the addressed comments and resolve the conversations myself > > fair comment @echauchot, but I guess we have to meet somewhere in the middle ... that would make addressing comments more than a hassle yes somewere in the middle looks good to me. What I advice is what I do when I'm being reviewed but it is true that sometimes I commit more than one change and it requires that I split the commit afterwards. Painful ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
