lostluck commented on issue #22404: URL: https://github.com/apache/beam/issues/22404#issuecomment-1192052183
Discussing this with @robertwb and @reuvenlax indicates that this is something incorrect in the Go SDK, and shouldn't be included. By the Model and the Coders, the timestamps for individual values are either combined (in the GBK case) or dropped after being used for window assignment (for Side inputs). So ultimately, instead we need to simply fail these pipelines at construction time (with an error referring to this issue and explain this part of the model). There are also some bad tests & documentation that need correction. https://github.com/apache/beam/blob/8b213c617ef8cf3a077bb0002b6b0fec8e85cb05/sdks/go/pkg/beam/core/funcx/sideinput.go#L59 https://github.com/apache/beam/blob/273613dbdf2566a3975d5f47f581a861a91128b8/sdks/go/pkg/beam/core/funcx/sideinput_test.go#L34 legacy template: https://github.com/apache/beam/blob/410ad7699621e28433d81809f6b9c42fe7bd6a60/sdks/go/pkg/beam/core/runtime/exec/optimized/inputs.tmpl#L33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
